Removing loop name from asyncio.create_task #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
vgvoleg
reviewed
Sep 26, 2024
ydb/_topic_common/common.py
Outdated
| def wrap_create_asyncio_task(func: typing.Callable, task_name: str, *args, **kwargs): | ||
| if sys.hexversion < 0x03080000: | ||
| return asyncio.create_task(func(*args, **kwargs)) | ||
| return asyncio.create_task(func(*args, **kwargs), name=task_name) |
There was a problem hiding this comment.
It seems weird how we pass name and args. This wrapper could get already created task and use task.set_name(name) in case of python 3.8+. In this case you will don't have any problems between asyncio.create_task() and loop.create_task() because they both return a Task you can pass into your wrapper
Also this wrapper could have a better name, because the current one doesn't explain anything we do with the task.
I don't have anything against hexversion, but I'm sure we can omit this check on every wrapper call. We could use this split during function declaration stage. In this case, if we will have only one if call, think about switching to version_info for better readability (i'm not insist here)
vgvoleg
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding python 3.7 support for the ydb topic.
Pull request type
Please check the type of change your PR introduces:
Other information
Removing loop name from asyncio.create_task, since it only appeared in python3.8.